Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intent in get_initial_step #17

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

ivan-pi
Copy link
Collaborator

@ivan-pi ivan-pi commented Feb 6, 2022

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #17 (92911cf) into main (7e26398) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files           8        8           
  Lines         563      563           
  Branches      153      153           
=======================================
  Hits          166      166           
  Misses        274      274           
  Partials      123      123           
Impacted Files Coverage Δ
src/nlopt_wrap.f90 12.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e26398...92911cf. Read the comment docs.

@ivan-pi
Copy link
Collaborator Author

ivan-pi commented Feb 7, 2022

I just noticed that several other getters also have attribute intent(inout). Is that a conscious decision?

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I used intent(inout) everywhere. One option for error handling was to have an internal state, which saves the last error, in this case the instance could always be changed. But that is not how I implemented things in the end, so we can switch to intent(in) where possible.

@awvwgk awvwgk merged commit 7dc4443 into grimme-lab:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants