Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient had wrong dimension for mfunc constraints. #20

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

Nicholaswogan
Copy link
Contributor

I think this is all that is needed to resolve #19 . The wrapper appears to be working for my use case (which uses a mfunc constraint).

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #20 (4c6e28c) into main (b87ecb9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files           8        8           
  Lines         563      563           
  Branches      153      153           
=======================================
  Hits          166      166           
  Misses        274      274           
  Partials      123      123           
Impacted Files Coverage Δ
src/nlopt_callback.f90 20.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87ecb9...4c6e28c. Read the comment docs.

@awvwgk awvwgk merged commit 8e36c15 into grimme-lab:main Feb 14, 2022
@Nicholaswogan Nicholaswogan deleted the jacobian_patch branch February 14, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradient has the wrong dimension?
2 participants