Skip to content

[Build] Add Code Quality workflow #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

riedgar-ms
Copy link
Collaborator

@riedgar-ms riedgar-ms commented May 29, 2025

Add a workflow for checking code quality. This runs ruff twice, once to check the formatting, once to check the import sorting. According to the ruff docs, these two things cannot currently be done in a single command. Currently, this should show up as a 'neutral' check for PRs.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.33%. Comparing base (40f719c) to head (94cac6d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (40f719c) and HEAD (94cac6d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (40f719c) HEAD (94cac6d)
20 15
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   63.56%   58.33%   -5.24%     
==========================================
  Files          62       62              
  Lines        4663     4663              
==========================================
- Hits         2964     2720     -244     
- Misses       1699     1943     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@riedgar-ms riedgar-ms requested review from nopdive and paulbkoch May 29, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants