Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-plugin module config to lint/coverage feature #1013

Merged
merged 3 commits into from
Jun 26, 2021
Merged

Add eslint-plugin module config to lint/coverage feature #1013

merged 3 commits into from
Jun 26, 2021

Conversation

Nargonath
Copy link
Member

Since we published a new version of the @hapi/eslint-plugin with a new configuration @hapi/module we want to migrate the inner configuration declared in lib/linter/.eslintrc.js to use the new configuration.

@Nargonath Nargonath added the feature New functionality or improvement label Jun 20, 2021
@Nargonath Nargonath marked this pull request as ready for review June 25, 2021 17:13
@Nargonath Nargonath self-assigned this Jun 25, 2021
@Nargonath Nargonath requested a review from nlf June 25, 2021 17:24
nlf
nlf approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable to me, and we know how to fix it if someone is mucking about in the require cache and it becomes a problem. i'm a big fan of starting simple 👍

@Nargonath
Copy link
Member Author

I totally agree. Thanks. 👍

@Nargonath Nargonath merged commit b087803 into master Jun 26, 2021
@Nargonath Nargonath deleted the use-eslint-module-configuration branch June 26, 2021 11:05
@Nargonath Nargonath mentioned this pull request Jun 29, 2021
Closed
@Nargonath Nargonath added this to the v24.3.0 milestone Jun 29, 2021
@kanongil kanongil mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees

@Nargonath Nargonath

Labels
feature New functionality or improvement
Projects
None yet
Milestone
v24.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Nargonath @nlf