feat: add explicit extension support when using Typescript and ESM #1073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention on Typescript when using ESM is to require .js files while actually expecting .ts files to be imported, this fails with current lab as obviously the .js file doesn't exist and the
require.extentions
hook doesn't even get a chance to run.I inspired myself from ts-node for this (especially https://github.com/TypeStrong/ts-node/blob/main/src/cjs-resolve-hooks.ts), but I don't think I need everything as this is just enough to make it work. This is very specifically tailored for the scenario I'm seeing, I'm not sure that it covers everything out there.