Skip to content

Add support for DefaultSignatures extension #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

phischu
Copy link
Contributor

@phischu phischu commented Jun 11, 2014

Hi, this is my attempt to add support for the DefaultSignatures extension. Probably someon should add a link in #19.

@pjonsson
Copy link
Contributor

I looked at the code and that looks reasonable. The contributing file mentions that new tests should be added in a separate commit.

With that said I'm still not qualified to comment on the general design, so someone else needs to merge this.

@UnkindPartition
Copy link
Member

Merged, thanks!

@pjonsson thanks for reviewing!

@UnkindPartition
Copy link
Member

This test no longer passes. I'm looking into it.

@pjonsson
Copy link
Contributor

I haven't run this so I don't know what is breaking, but if it's Names here's an idea:

I changed some of the source points to properly represent parenthesis and keep the underlying variable positions in 2970107. This could mean that there are fewer sourceInfoPoints stored in the tree now compared to when the patch was constructed.

@UnkindPartition
Copy link
Member

It looks like 562ebd0 broke it. I guess I should just rebase the test.

@UnkindPartition
Copy link
Member

Should be fixed by fcdaf2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants