avoid bad duplicate module checks #7615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test this a bit before merge, and possibly we want to introduce an explicit regression test for it as well... |
phadej
reviewed
Sep 3, 2021
| ab = a <> b | ||
|
|
||
| -- if something exists in both branches of a conditional, only add it once | ||
| o x y = x ++ filter (not . (`elem` x)) y |
There was a problem hiding this comment.
There was a problem hiding this comment.
The intent isn't exactly like ordNub -- it preserves duplication as long as that duplication exists already in either of the branches. So if x or y contains duplicates, then x o y should also contain them. (And as I write this, I see where it actually fails to have that semantics fully, but that's the intention, at least !).
|
Actually this approach isn't the cleanest -- the conditional logic is trickier to capture than I think this newtype approach allows. Will close and try a different angle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4629
This tries to be relatively minimal, by introducing a special flattening call which attempts to merge conditionals without introducing spurious duplication.