Skip to content

Candidate maintenance only partly implemented #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edsko opened this issue Sep 24, 2013 · 3 comments
Closed

Candidate maintenance only partly implemented #72

edsko opened this issue Sep 24, 2013 · 3 comments

Comments

@edsko
Copy link
Contributor

edsko commented Sep 24, 2013

The package page for a candidate currently shows two "maintain" links -- one at the top [maintain] and one at the bottom in the "Maintainers Corner". The latter refers to a non-existent URL (actually, the URL is wrong, missing /candidate); the former gives a page that says

Here, you can delete a candidate, publish it, upload a new one, and edit the maintainer group.

except that you cannot in fact do anything on that page (there are no links at all).

  • Publishing a candidate is partly implemented (but see Publishing a candidate does not transfer already-built docs #70 and Publishing a candidate does not delete the candidate #71) through http://example.com/package/package-name-X.Y.Z/candidate/publish (GET shows the "Publish" form, POST actually does the publishing) so that should be easy to add;
  • Deleting is also implemented but only through a HTTP DELETE request of http://example.com/package/package-name-X.Y.Z/candidate so that requires a little more work to make that available through the web interface.
  • For uploading obviously we can use the existing candidate upload form
  • For editing the maintainer group etc., we should probably make sure that the "Maintainer's Corner" works just like it does for regular packages.
@gracenotes
Copy link
Contributor

This is from the XHtml-generating function serveCandidateMaintain in Html.hs. Should this be ripped out, and a template used instead?

@adamgundry
Copy link
Member

I'll look at this. For deleting packages, I guess we want to create a page at http://example.com/package/package-name-X.Y.Z/candidate/delete that shows a form on GET and deletes on POST?

adamgundry added a commit to adamgundry/hackage-server that referenced this issue Oct 1, 2013
adamgundry added a commit to adamgundry/hackage-server that referenced this issue Oct 1, 2013
adamgundry added a commit to adamgundry/hackage-server that referenced this issue Oct 1, 2013
adamgundry added a commit to adamgundry/hackage-server that referenced this issue Oct 1, 2013
@adamgundry
Copy link
Member

See #115. Sorry for the noise, I thought I'd get away with that rebase!

@dcoutts dcoutts closed this as completed in 9ea7763 Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants