Add captcha for user registration #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch, it's the dependencies! I'll fix them soon. |
|
I've tested it in my own repo's CI. |
freizl
reviewed
Oct 4, 2022
| var hash = document.getElementById("hash"); | ||
|
|
||
| function changeCaptcha() { | ||
| var xmlHttp = new XMLHttpRequest(); |
There was a problem hiding this comment.
Sorry for being busy these days. I'm not familiar with javascript; is there a reason for preferring fetch to XMLHttpRequest?
There was a problem hiding this comment.
Generally it is easier to use than XMLHttpRequest.
It doesn't support IE, but who cares IE. :D
gbaz
added a commit
that referenced
this pull request
Jan 5, 2023
* delete unused GitHub Action; fix CI badge * Fix #1076: separate validators from UI and doctest them (#1077) * Cachix caching for nix-shell GitHub Action (#1081) * Add uploaded_at field in package api (#1080) * package page: Include virtual-modules in module tree (#1085) * Allow hashable-1.4 and text-2.0 (#1089) * Divide sitemap into parts * Add sitemap link for subdirectories * Fix `non-canonical-return` warnings * Bump CI to GHC 9.2.3 and restrict to master branch * Check authorisation (#1111) * Dynamically add css piece * Fix #1105: change order of markdown parsers to allow pipes in lists * Fix #1128, fix #1130 by adding bounds to Cabal-syntax and haddock-library * Bump CI to 9.2.4 and some deps * Force .txt and .text to have UTF-8 MIME charset (#1133) * Upgrade to haddock-library-1.11.0 (#1126) * attempt to speed up GitHub Action for Nix Shell * work with cabal 3.8 * Updated accepted licenses (#1092) * Add dependabot for github workflows * Bump cachix/cachix-action from 10 to 12 * Bump actions/checkout from 2.4.0 to 3.1.0 * Bump cachix/install-nix-action from 17 to 18 * Build with Cabal-3.8 and GHC 9.4 (#1141) * Haskell CI: bump to Ubuntu-22.04, GHC 9.2.5 and 9.4.4 * Allow mtl-2.3 and transformers-0.6 (#1150) * Disable test (#1124) * allow disable tests on client side * add deprecated version warning (#1123) * List maintainers on package page (#1098) * List maintainers on package page * Vendor snowball package (#1116) * Add searchbox metadata (#1115) * Add captcha for user registration (#1099) * remove filtering 00-index for cabal version < 2.0 hack (#1152) * Add lastVersion in listings (#749) (#1140) * rm icu dep instructions, add libgd * Add test log display (#1100) * Add test log * Reverse Dependencies indexed on PackageName (#1082) * Rebased Reverse Dependencies * Add "Quick Jump" to candidate package page (#1122) * Solves #1029 - Adds paging to recent packages and recent revisions (#1055) * support for `prefers-color-scheme` (#1008) * 2x brightness for captions and links in dark color scheme * table dark color scheme * prefers-color-scheme for links, footer, and table-of-contents * paginator css for `prefers-color-scheme` * Maintainer notifications * cleanup partial functions for revdeps, elim use of MonadThrow, MonadCatch * fix tests enablement link Co-authored-by: Peter Becich <peterbecich@gmail.com> Co-authored-by: Andreas Abel <andreas.abel@ifi.lmu.de> Co-authored-by: Hécate Moonlight <Kleidukos@users.noreply.github.com> Co-authored-by: Matthew Pickering <matthewtpickering@gmail.com> Co-authored-by: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com> Co-authored-by: Alias Qli <2576814881@qq.com> Co-authored-by: Ondřej Kubánek <71923533+kubaneko@users.noreply.github.com> Co-authored-by: Gautier DI FOLCO <gautier.difolco@gmail.com> Co-authored-by: Janus Troelsen <ysangkok@gmail.com> Co-authored-by: Levi Butcher <31522433+LeviButcher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements #1090 as a gsoc project mentored by @gbaz. Looks like this:
Note:
gd, which in turn requires some system packages to be installed. Seeshell.nixfor newly added dependencies.SignupRequest.html.st. The file in this repo seems to be different from that on the working hackage server, so when deployed, modify the file correspondingly.I know little about html and javascript, so please point out if I got something wrong.