-
Notifications
You must be signed in to change notification settings - Fork 200
Upload page improvements #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,15 +39,9 @@ the <code>Maintainer</code> field as above either to commit to supporting the fo | |
yourself or to mark it as unsupported. | ||
</p> | ||
|
||
<p>Note that all of the above is a makeshift upload policy based on the features | ||
available in the newer hackage-server. The <code>Maintainer</code> field has its uses, | ||
as does maintainer user groups. The libraries mailing list should probably | ||
determine the best approach for this. | ||
</p> | ||
|
||
<h3>Upload forms</h3> | ||
<p>Some last formalities: to upload a package, you'll need a Hackage | ||
<a href="accounts.html">username</a> and password. (Alternatively, there's a | ||
<a href="accounts">username</a> and password. (Alternatively, there's a | ||
command-line interface via cabal-install, which also needs the same username | ||
and password.) | ||
</p> | ||
|
@@ -72,37 +66,32 @@ See the notes at the bottom of the page. | |
</li> | ||
|
||
<li> | ||
Categories are determined by whatever you put in the <code>Category</code> field | ||
(there's no agreed list of category names yet). | ||
Categories are determined by whatever you put in the <code>Category</code> field. | ||
You should try to pick existing categories when possible. | ||
You can have more than one category, separated by commas. If no other versions of | ||
the package exist, the categories automatically become the package's tags. | ||
</li> | ||
|
||
<li> | ||
Documentation for library packages should be generated by a maintainer. | ||
The means of doing this is still up in the air. | ||
Occasional changes to the GHC base package can mean that some work needs to be done to make packages compatible across a range of versions. | ||
See <a href="https://github.com/haskell-infra/hackage-trustees/blob/master/cookbook.md">these notes</a> for some tips in how to do so. | ||
|
||
There are some notes for upgrading <a href="http://www.haskell.org/haskellwiki/Upgrading_packages">much older</a> packages as well. | ||
</li> | ||
|
||
<li> | ||
We have moved to Haddock 2, and expect some glitches. | ||
<h3>Documentation</h3> | ||
|
||
If you notice anything broken, please report it on the | ||
<a href="http://trac.haskell.org/haddock">Haddock bug tracker</a>. | ||
</li> | ||
<p> | ||
The hackage-server attempts to build documentation for library packages, but this can fail. Maintainers can generate their own documentation and upload it by using something along the lines of the shell script below (note that the last two commands are the key ones):</p> | ||
<pre> | ||
set -e | ||
|
||
<li> | ||
In GHC 6.8, several modules were split from the <code>base</code> package | ||
into other packages. | ||
dir=$(mktemp -d dist-docs.XXXXXX) | ||
trap 'rm -r "$dir"' EXIT | ||
|
||
See <a href="http://www.haskell.org/haskellwiki/Upgrading_packages">these notes</a> | ||
on making packages work with a range of versions of GHC. | ||
</li> | ||
|
||
<li> | ||
While <a href="http://www.haskell.org/haddock/">Haddock 2</a> | ||
accepts GHC features, it is also more picky about comment syntax than | ||
the old version. | ||
</li> | ||
cabal haddock --builddir="$dir" --for-hackage --haddock-option=--hyperlinked-source | ||
cabal upload -d $dir/*-docs.tar.gz | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that starting with cabal 2.0 one also needs to use the |
||
</pre> | ||
|
||
</ul> | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the
builddir
argument?