Skip to content

The eval plugin should use the same default language extensions as ghci. #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fmehta opened this issue Jun 21, 2021 · 0 comments · Fixed by #1596
Closed

The eval plugin should use the same default language extensions as ghci. #1954

fmehta opened this issue Jun 21, 2021 · 0 comments · Fixed by #1596
Labels
component: hls-eval-plugin type: enhancement New feature or request

Comments

@fmehta
Copy link
Contributor

fmehta commented Jun 21, 2021

While working on #1591 it was noticed that the current default language extensions for the eval plugin were different from those in ghci. It is advantageous that both are identical.

Related comment in context: #1596 (comment)
@fmehta fmehta mentioned this issue Jun 21, 2021
Merged
@jneira jneira linked a pull request Jun 22, 2021 that will close this issue
Make the eval plugin use the same default language extensions as ghci. #1596
Merged
@mergify mergify bot closed this as completed in #1596 Jun 23, 2021
mergify bot added a commit that referenced this issue Jun 23, 2021
@fmehta @jneira
@berberman @mergify
Make the eval plugin use the same default language extensions as ghci. (
9f4220f 
#1596)

* Enable ExtendedDefaultRules for expressions in eval plugin (#1591)

* Add tests for fix#1591

* Add fix for #1954

* Remove dependency on xopt_set_unlessExplSpec.
Reason: It was breaking GHC 8.6.2 tests.

* Remove unnecessary comment.

Co-authored-by: Potato Hatsue <berberman@yandex.com>

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: Potato Hatsue <1793913507@qq.com>
Co-authored-by: Potato Hatsue <berberman@yandex.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: hls-eval-plugin type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the eval plugin use the same default language extensions as ghci.
2 participants
@jneira @fmehta