-
-
Notifications
You must be signed in to change notification settings - Fork 388
Mergify: create configuration #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c65523f
to
b5413b6
Compare
b5413b6
to
c2860a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, thanks @jneira
.github/mergify.yml
Outdated
- status-success=test (8.6.4, ubuntu-latest) | ||
- status-success=test (windows-latest, 8.10.2.2) | ||
|
||
- 'status-success=ci/circleci: cabal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we drop this one since the cabal build is already covered by the GitHub Actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, maybe we should remove it entirely, but we can start not adding here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed it in #1152
- 'status-success=ci/circleci: ghc-8.10.2' | ||
- 'status-success=ci/circleci: ghc-8.6.5' | ||
- 'status-success=ci/circleci: ghc-8.8.4' | ||
- 'status-success=ci/circleci: ghc-default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop this one since it's unclear what ghc-default
means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ghc-default
is using the default stack.yaml
, without version
maybe we should change the name in ci (and here too, but keeping it in any case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted it in #1152
I enabled the Mergify integration with this Github repo, but it needs to be validated by an admin of the Haskell org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the concept.
And happy with squash or merge as strategy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
merge me
labelmerge me
labelOf course, it requires install the mergify app in the repo