Skip to content

Trace more Shake evaluation details #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2021
Merged

Trace more Shake evaluation details #1861

merged 3 commits into from
May 26, 2021

Conversation

pepeiborra
Copy link
Collaborator

Opentelemetry traces have proven very useful for understanding the evaluation and performance of the Shake rules. This change adds more information to those traces:

  • What mode a rule is running in - is this a full rerun (dependencies changed) or just a lookup in the values state?
  • Whether the rule value changed after running

image

@pepeiborra pepeiborra force-pushed the trace-shake-details branch from 6d5279c to b42a26e Compare May 23, 2021 20:11
@pepeiborra pepeiborra force-pushed the trace-shake-details branch from c671c0c to 9ac39e8 Compare May 24, 2021 06:45
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label May 26, 2021
@mergify mergify bot merged commit 204fdcb into master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants