Add qualified imports in postfix position when ImportQualifiedPost and WarnPrePositiveQualifiedModule are set
#3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3kyro
force-pushed
the
postqualified-import-codeaction
branch
from
dc27803 to
5699deb
Compare
fendor
reviewed
Dec 15, 2022
3kyro
force-pushed
the
postqualified-import-codeaction
branch
2 times, most recently
from
3a65034 to
5257dc7
Compare
3kyro
force-pushed
the
postqualified-import-codeaction
branch
5 times, most recently
from
7bbb589 to
e1f7507
Compare
fendor
requested changes
Dec 24, 2022
|
@fendor thanks, I couldn't find a way to set |
fendor
approved these changes
Dec 24, 2022
The test fails with: test\functional\FunctionalCodeAction.hs:116: expected: "Not in scope: \8216Control.when\8217\nNo module named \8216Control\8217 is imported." but got: "Variable not in scope: when :: Bool -> IO () -> IO ()" Seems like diagnostics for missing variables differ
3kyro
force-pushed
the
postqualified-import-codeaction
branch
from
841265d to
526221c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
ImportQualifiedPostlanguage extension and the-warnPrePositiveQualifiedModuleenabled, the default behavior of the import-export plugin to add qualified imports in prefix position produces a warning. This PR changes the position of thequalifieddescriptor to postfix when the above two conditions are met. This is a partial fix for #3362.