Skip to content

Enable hls-stan-plugin for GHC 9.10.1 #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Enable hls-stan-plugin for GHC 9.10.1 #4437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1297547
Enable hls-stan-plugin for GHC 9.10.1
fendor Oct 21, 2024
5bc76c7
Merge branch 'master' into fendor/ghc910/plugins
soulomoon Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ jobs:
name: Test hls-splice-plugin
run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests

# TODO enable when it supports 9.10
- if: matrix.test && matrix.ghc != '9.10'
- if: matrix.test
name: Test hls-stan-plugin
run: cabal test hls-stan-plugin-tests || cabal test hls-stan-plugin-tests

Expand Down
2 changes: 1 addition & 1 deletion cabal.project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ packages:
./hls-test-utils


index-state: 2024-08-22T00:00:00Z
index-state: 2024-10-21T00:00:00Z

tests: True
test-show-details: direct
Expand Down
2 changes: 1 addition & 1 deletion docs/support/plugin-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ For example, a plugin to provide a formatter which has itself been abandoned has
| `hls-overloaded-record-dot-plugin` | 2 | |
| `hls-semantic-tokens-plugin` | 2 | |
| `hls-floskell-plugin` | 3 | 9.10.1 |
| `hls-stan-plugin` | 3 | 9.10.1 |
| `hls-stan-plugin` | 3 | |
| `hls-retrie-plugin` | 3 | 9.10.1 |
| `hls-splice-plugin` | 3 | 9.10.1 |
6 changes: 3 additions & 3 deletions haskell-language-server.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,13 +791,13 @@ flag stan
manual: True

common stan
if flag(stan) && impl(ghc < 9.10.0)
if flag(stan)
build-depends: haskell-language-server:hls-stan-plugin
cpp-options: -Dhls_stan

library hls-stan-plugin
import: defaults, pedantic, warnings
if flag(stan) && impl(ghc < 9.10.0)
if flag(stan)
buildable: True
else
buildable: False
Expand Down Expand Up @@ -825,7 +825,7 @@ library hls-stan-plugin

test-suite hls-stan-plugin-tests
import: defaults, pedantic, test-defaults, warnings
if flag(stan) && impl(ghc < 9.10.0)
if flag(stan)
buildable: True
else
buildable: False
Expand Down
Loading