Fix and revamp Stack dependencies #327
Conversation
1. Fix dependencies problems (mostly related to `resourcet`)
2. Remove extraneous stack.yaml files
3. Add and keep those stack.yaml files that are in the CI:
* ghc-8.4.4 - lts-12.26
* ghc-8.6.5 - lts-14.27
* ghc-8.8.3 - lts-16.11
* ghc-8.10.4 - lts-17.9
|
Hi, many thanks for the clean up, looks good to me, only curious about why there is a stack,yaml for 8.8,3 instead for 8.8.4 |
|
I followed the versions used by the Cabal CI lsp/.github/workflows/haskell.yml Line 12 in 3e688d9 We can use |
|
👀 |
|
are you gonna merge it or what? |
|
Sorry i lost track of this pr, thanks for pinging again. My idea was wait for another review of an actual stack user and maintainer of the repo, as we are not building with stack in ci. Specially taking in account some stack.yaml's are being deleted. |
|
@michaelpj are you using stack by chance? |
|
Nope, sorry. |
stack-8.4.4.yaml
Outdated
| # - some-1.0.1@sha256:26e5bab7276f48b25ea8660d3fd1166c0f20fd497dac879a40f408e23211f93e,2055 | ||
| # - stm-2.5.0.0@sha256:c238075f9f0711cd6a78eab6001b3e218cdaa745d6377bf83cc21e58ceec2ea1,2100 | ||
| # - transformers-0.5.6.2@sha256:6c959d14430f4deffb99579ba019de07c3d852a2122b6f449344386c7d75ff1d,3172 | ||
| # - unliftio-core-0.2.0.1@sha256:9b3e44ea9aacacbfc35b3b54015af450091916ac3618a41868ebf6546977659a,1082 |
|
I am a little bit worried for the dissymmetry between the versions supported with this pr an haskell-language-server, one of the main clients of the library. In hls we have stack-8.6.4.yaml, stack-8.8.2.yaml, stack-8.8.3.yaml, stack-8.10.2.yaml and stack-8.10.3.yaml. |
|
I agree that asymmetry between this package and HLS make the situation complicated. FWIW, I think adding or removing a stack version without a really good reason is OK, but removing (and maybe adding too) a stack version (even with a good reason) should be handled in a synchronized manner with HLS maintainers. |
|
@banacorn to be fair, the pr only removes 8.6.4 (8.8.1 and 8.8.2 too but they are not present or about to be removed in hls) so i would only ask to restore it and keep the actual ones. Other ones could be added afterwards. |
|
I'm not sure if I'm getting it right, so I made a table, please edit the PR change column so that I can make this PR right
Also, should we add 8.10.2 instead of 8.10.4?
|
|
@banacorn thanks for the nice summary, i've edited it to make clear what is our intent. |
|
I've added those missing stack files and made a summary at the top |
|
I am building in windows some of the stack.yaml's as final sanity check, will merge asap Ideally we should have some ci jobs building the project with stack (maybe without testing). For my experience, without ci checking them, stack.yaml's get out of sync quickly. |
|
@banacorn many thanks for the pr and your patience, i've tried some of them in my local windows and all builds have been succesfull. |
resourcetfromconduitinlsp-test)I'm going to make another PR to include Stack in the CI.
So that we can solve these Stack dependency problems once and for all.
edit: Stack image version changes made by this PR