Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call hierarchy support #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call hierarchy support #332
Changes from all commits
ec01720
e95835b
a540245
6d165ed
cd501e5
4998fcc
ef59c28
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include haddock corresponding to the doc in the LSP spec for each item? Tedious, but matching the spec is a simple policy and more field documentation is almost always better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it look like this? I have little knowledge about haddock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
Maybe
is not necessaryList
should have thatnull
coveredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just keep it to satisfy the spec. And I still notice that we have several dealings about
null
, for example:Maybe
to representnull
.lsp/lsp-types/src/Language/LSP/Types/Message.hs
Line 168 in 3e688d9
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_hover
null
.lsp/lsp-types/src/Language/LSP/Types/Message.hs
Line 169 in 3e688d9
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_signatureHelp
lsp/lsp-types/src/Language/LSP/Types/Message.hs
Line 205 in 3e688d9
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_workspaceFolders
Maybe we need to unify them under one specific rule.