Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Default Hotkey "Ctrl, Alt + Q" makes it impossible to type "@" on German keyboards #62

Closed
2 of 4 tasks
EpicLPer opened this issue Mar 9, 2024 · 8 comments
Closed
2 of 4 tasks
Labels
bug Something isn't working
Milestone

Comments

@EpicLPer
Copy link

EpicLPer commented Mar 9, 2024

Please make sure that the issue you're planning to report is not already registered :)


Describe the bug
For the past days I've been wondering why I can't type the "@" symbol on my keyboard anymore. After digging around and realizing that the only app I've installed lately was HASS.Agent I found that the default hotkey of "Ctrl, Alt + Q" is resulting in this. The combination or "Alt Gr + Q" is usually reserved for @ on that layout. Disabling the hotkey inside HASS.Agent makes @ work again just fine.

To Reproduce
Steps to reproduce the behavior:

  1. Have a German keyboard
  2. Install HASS.Agent
  3. The hotkey is by default enabled, so the bug should be reproducible at this point already

Expected behavior
"@" symbol should still work on German keyboards

Screenshots
-

Misc info (please complete the following information):

  • Windows build (ideally screenshot/info of winver.exe output): Windows 11 23H2
  • Windows' UI language: English (German Keyboard)
  • HASS.Agent version: 2.1.0-beta1

Please check what's applicable (multiple answers possible):

  • Installed via installer
  • Installed manually
  • Problem occurs in HASS.Agent
  • Problem occurs in Satellite Service

Additional context
-

Logs
-

@EpicLPer EpicLPer added the bug Something isn't working label Mar 9, 2024
@amadeo-alex
Copy link
Collaborator

While I don't think that having both the hotkey and "@" working at the same time, I think we can add a logic that will alter the default hotkey if german keyboard layout is detected.
Any "german safe" hotkey combinations that you can suggest?

@EpicLPer
Copy link
Author

From my tests "AltGr + H" should fit well :)
Else, potential different solution: Detect the layout > If it's German warn the user and ask him to make a new shortcut

@amadeo-alex
Copy link
Collaborator

Now I'm surprised, there is a check for "input language" being German in the code already :D
Did you by any chance receive that during the initial onboarding/configuration after installation?
Should be something like:

Your input language '{0}' is known to collide with the default CTRL-ALT-Q hotkey. Please set your own.

I'll also check if there is difference between C# input language and keyboard layout - maybe this is what we're missing.

@amadeo-alex
Copy link
Collaborator

@EpicLPer could you please execute following in powershell and provide me with output?

Get-WinUserLanguageList

It should respond back with something like this:
GRAa5A

@EpicLPer
Copy link
Author

EpicLPer commented Apr 8, 2024

Hi, sorry for the late reply.
The output is as follows:

LanguageTag     : de-AT
Autonym         : Deutsch (Österreich)
EnglishName     : German
LocalizedName   : German (Austria)
ScriptName      : Latin
InputMethodTips : {0C07:00000407}
Spellchecking   : True
Handwriting     : False

LanguageTag     : en-AT
Autonym         : English (Austria)
EnglishName     : English
LocalizedName   : English (Austria)
ScriptName      : Latin
InputMethodTips : {2000:00000407}
Spellchecking   : True
Handwriting     : False

amadeo-alex added a commit that referenced this issue May 1, 2024
This PR adds additional check for the german input language being installed on system.
Should remediate cases where mixed language systems (English UI with German keyboard layout) do not present the notification regarding HotKey collision - #62
@amadeo-alex amadeo-alex added this to the 2.1.0-beta2 milestone May 1, 2024
@amadeo-alex
Copy link
Collaborator

Reopened until 2.1.0-beta2 is released for clarity sake.

@amadeo-alex amadeo-alex reopened this May 2, 2024
@erd82
Copy link

erd82 commented May 16, 2024

Having exactly the same problem, that I cannot type email addresses (at-key) anymore once HASS Agent is running. So the application cannot run constantly in the background.

image

@amadeo-alex
Copy link
Collaborator

Having exactly the same problem, that I cannot type email addresses (at-key) anymore once HASS Agent is running. So the application cannot run constantly in the background.

image

To fix that for now, please modify the hotkey shortcut to something else like Alt+H.
Next version fo HASS.Agent will warn about this during onboarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants