Feat/auto group #162
Merged
Feat/auto group #162
+471
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leave waiting list auto group api auto group from host
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Missing translation | 7 | warning | contribute (via Fink 🐦) |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new features to enhance session group management and waitlist functionality.
- Implements new waitlist endpoints and messaging.
- Adds auto-grouping functionality for dynamically assigning participants to groups.
- Updates session schema and settings to support the new features.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/api/session/[id]/settings/+server.ts | Adds GET and POST endpoints to update and fetch session settings. |
| src/routes/api/session/[id]/action/[action]/+server.ts | Implements waitlist join and leave actions with permission checks. |
| src/lib/schema/session.ts | Updates session schema to include autoGroup settings and waitlist. |
| src/routes/api/session/+server.ts | Updates session initialization to include autoGroup settings. |
| src/routes/api/session/[id]/group/auto_group/+server.ts | Creates auto-grouping logic including group creation and member join. |
Comments suppressed due to low confidence (1)
src/routes/api/session/[id]/group/auto_group/+server.ts:81
- The error thrown when no members are provided uses the members array as the error message, which is unclear. Consider using a descriptive message like 'No members provided for group creation'.
if (members.length === 0) { throw error(400, members); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements related to group management and waitlist functionality in the session component. The most important changes include adding waitlist management, implementing auto-grouping functionality, and updating session settings to support these features.
Waitlist Management:
messages/en.jsonandmessages/zh.json[1] [2].ParticipantView.svelte[1] [2].Auto-grouping Functionality:
HostView.svelteto automatically assign participants to groups based on the number of groups specified [1] [2].autoGroupsettings and waitlist array insession.ts.auto_group/+server.ts(src/routes/api/session/[id]/group/auto_group/+server.tsR1-R104).Session Settings:
autoGroupsettings insession/+server.ts.action/[action]/+server.ts(src/routes/api/session/[id]/action/[action]/+server.tsL21-R27, src/routes/api/session/[id]/action/[action]/+server.tsR59-R117).Miscellaneous:
HostView.svelteandParticipantView.svelte[1] [2].ParticipantView.svelte[1] [2].