Fix Ephember cannot connect #140367
Fix Ephember cannot connect #140367
Conversation
home-assistant
bot
added
bugfix
cla-signed
integration: ephember
small-pr
|
Hey there @ttroy50, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
changed the title
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
The owner of pyephember isn't online for a number of years. Can you advise on what's the best course of action to take ? My account has access on the pypi to update the package there but not the GitHub for it. > Please read and fill in the PR checklist correctly according to what you have done. You're missing some required steps there. |
|
If you have tried to contact the original author, asking them to share or transfer maintenance to you, without success, I suggest you rename the package and publish it as a new project on GitHub and PyPI. Give credit to the original author in the renamed project but publish it as a separate project, not a fork, since you're not planning to continue development of the original project. We require 3rd party dependencies to make the source available in a public online code repository, eg GitHub, and releases published on PyPI should correspond to the releases on the public online code repository, such as GitHub. |
|
Thank you.
I have complete this now as package pyephember2. If this is okay I will
proceed to update the integration to use this package instead.
…On Tue 11 Mar 2025, 23:29 Martin Hjelmare, ***@***.***> wrote:
If you have tried to contact the original author, asking them to share or
transfer maintenance to you, without success, I suggest you rename the
package and publish it as a new project on GitHub and PyPI.
Give credit to the original author in the renamed project but publish it
as a separate project, not a fork, since you're not planning to continue
development of the original project.
We require 3rd party dependencies to make the source available in a public
online code repository, eg GitHub, and releases published on PyPI should
correspond to the releases on the public online code repository, such as
GitHub.
—
Reply to this email directly, view it on GitHub
<#140367 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVJ7EOX5I33L7562VO3XNT2T5WUHAVCNFSM6AAAAABYY2SFJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJVHE2TANBRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: MartinHjelmare]*MartinHjelmare* left a comment
(home-assistant/core#140367)
<#140367 (comment)>
If you have tried to contact the original author, asking them to share or
transfer maintenance to you, without success, I suggest you rename the
package and publish it as a new project on GitHub and PyPI.
Give credit to the original author in the renamed project but publish it
as a separate project, not a fork, since you're not planning to continue
development of the original project.
We require 3rd party dependencies to make the source available in a public
online code repository, eg GitHub, and releases published on PyPI should
correspond to the releases on the public online code repository, such as
GitHub.
—
Reply to this email directly, view it on GitHub
<#140367 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVJ7EOX5I33L7562VO3XNT2T5WUHAVCNFSM6AAAAABYY2SFJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJVHE2TANBRHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes, that's ok. |
Update Clime Platform Schema `homeassistant.components.climate.PLATFORM_SCHEMA` should be imported as `CLIMATE_PLATFORM_SCHEMA`RuffICN001
|
|
||
| OPERATION_LIST = [HVACMode.HEAT_COOL, HVACMode.HEAT, HVACMode.OFF] | ||
| OPERATION_LIST = [HVACMode.AUTO, HVACMode.HEAT, HVACMode.OFF] |
There was a problem hiding this comment.
Why do we change from HEAT_COOL to AUTO? The auto mode has specific meaning in Home Assistant.
core/homeassistant/components/climate/const.py
Lines 21 to 23 in 2f1ff5a
There was a problem hiding this comment.
In this case the thermostat will use the Schedule it has built in.
There was a problem hiding this comment.
heat_Cool is never an option for Ember heating systems they are gas boilers.
There was a problem hiding this comment.
Is it correct that the user can't adjust the temperature when in the AUTO device mode?
There was a problem hiding this comment.
eTrv device and some thermostats can change temperature only in Manual/ON mode.
I think AUTO is more accurate mode. In AUTO mode devices use schedule and target temp.
Heat/Cool never exists in EPH devices.
There was a problem hiding this comment.
We do not allow using auto mode if temperature can be changed by the user.
|
They can adjust the temperature when in Auto mode.
Auto just set's the EPHEMber to use it's schedule.
Temp adjust is for Both Auth and Heat modes.
Temperature changing is not allowed on the DeviceType = 4 which is a hot
water heating cycle.
In those cases it should take the temperature that is set on the device and
not allow it to be changed.
Kind Regards,
Robert
…On Wed, 12 Mar 2025 at 13:15, Martin Hjelmare ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In homeassistant/components/ephember/climate.py
<#140367 (comment)>
:
>
-OPERATION_LIST = [HVACMode.HEAT_COOL, HVACMode.HEAT, HVACMode.OFF]
+OPERATION_LIST = [HVACMode.AUTO, HVACMode.HEAT, HVACMode.OFF]
Is it correct that the user can't adjust the temperature when in the AUTO
device mode?
—
Reply to this email directly, view it on GitHub
<#140367 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVJ7EJMYC64VXOIQIJ2OQ32UAXQJAVCNFSM6AAAAABYY2SFJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNZYGQ2DKMBZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
We can't use |
|
The thermostat allows target temp change on Auto. |
|
|
|
I'm not a developer and am out of my depth committing these changes. If we can't fix or support this can we just cancel the official EPHEmber support on HA and we move this to HACS instead ? |
|
Is there a technical problem with keeping the device auto mode mapped to the On another note: We have deprecated https://developers.home-assistant.io/blog/2024/03/10/climate-aux-heater-deprecated The aux heat on/off should be moved to a switch entity if separate control of that feature while the device is on is needed. If it's enough to be able to turn on/off the device the climate entity can support Removing the aux heat feature can be done in a separate PR. |
|
Heat/Cool: The device is set to heat/cool to a target temperature range. |
|
Using HVACMode.Heat_Cool you need to set High and Low temp range and the thermostat only accepts one target temp to reach. The UI is poor. HVACMode.AUTO is preferrably as we are setting the Thermostat to be Schedule controlled as per the documentation. I did not see why we cannot use AUTO with a target temperature. |
Do you think there is no chance to complete the version update in the original ttroy50 repo? |
|
I can update PyPi directly for the pyephember package.Im a contributor there. I did it last week for version 0.4.1 with the mqtt API version fix. It just would be out of sync with its GitHub which is against HomeAssistant guidelines for pull requests. |
Proposed change
Update library to pyephember2 to 0.4.3 which has MQTT fix for API version to use.
Moved from pyephember as owner is no longer active.
https://github.com/roberty99/pyephember2
Update Climate.py to remove unused calls and also fix the HotWater to always be device id 4.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: