Increase resolution of sun updates around sunrise/sundown #140403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I have my external blinds set up to go down at -4° instead of 0° of sun elevation, because I enjoy watching the sunset. 🌆
I've noticed that that didn't really work as I expected it to so I went looking and found this ancient PR: #23832
I'd argue that with all the changes that happened to the recorder component, the problem that that PR solved back in 2019 probably doesn't exist anymore.
I'd even go so far to say that it probably needs no elevation-dependent resolution at all anymore, but for the sake of keeping the impact small, I've just bumped up each Civil Twilight and Nautical Twilight up one resolution level.
That should allow more use-cases to benefit from a reasonable update rate while still keeping the update rate down when not needed.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: