Fix s3-4c implementation #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the S3-aws4c implementation to the new AIORI interface and outsources the options into module-specific options.
An example usage is:
./ior -a=S3-4c --S3-4c.user=julian --S3-4C.host=localhost:9000
Credentials need to be stored in $HOME/.awsAuth, e.g.:
julian:accesskey:secretkey
Using the minio server as documented in testing/s3.sh
leads to an error:
CURL call failed at aiori-S3-4c.c, line 1258
ERROR: 411 '411 Length Required'
Which may be due to missing part in the XML. As the implementation and used library maybe a bit outdated, further checks are necessary.