-
Notifications
You must be signed in to change notification settings - Fork 260
Make regression tests only run on main
#975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
@@ -2,8 +2,12 @@ name: Regression tests | |||
|
|||
on: | |||
pull_request: | |||
branches: | |||
- main | |||
types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types
should not be needed here.
if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.
That does mean what you described. Whether or not that is what is actually desirable is debatable. Since you're the only one working directly in this repo, and you only work on |
Thanks! Note that I copied this from the compiler test workflow, so this is making those two workflows consistent. The immediate issue I'm trying to debug why MkDocs's workflow (which I've also called |
You can in fact just exclude the
|
@hsutter Would it be fine for you to go with my proposition of excluding |
@hsutter The update seems to work. However you still have regression tests running on your |
Fixed, thanks! |
I think this is the right way to express they should run on
main
and PRs onmain
... it doesn't need to run on thedocs
branch.@jarzec does this diff look right to accomplish that?