feat(attr-sort): sort unknown attributes alphabetically

[chrisguttandin]

Previously unknown attributes were just ignored. Now they get sorted alphabetically.

BREAKING CHANGE: HTMLHint will now throw an error if unkown attributes are not sorted.

fix #661

Short description of what this resolves:
This PR will make sure all attributes get sorted when using the attr-sorted rule. It will ensure that attributes linted with this rule will always get sorted the same way.

Please let me know if there is anything that should be changed to make this PR mergable.

[thedaviddias]

That's a pretty good addition! Thanks @chrisguttandin!

[coliff]

Heya @chrisguttandin - can you please resolve the conflicts so we can get this one merged? Thanks!

[chrisguttandin]

Hi @coliff, I've rebased the branch on top of the current master.

[chrisguttandin]

@coliff Is there anything I can do about the failing CI tasks?

[coliff]

Sorry for the delay - I think we need @thedaviddias for assistance on this.

[chrisguttandin]

Hi @coliff, should I maybe close this PR and create a new one with the same changes on top of the latest master?

[coliff]

hey @chrisguttandin - sorry for the trouble. We appreciate the PR and your patience with this - I know you opened this a long while back! :-)

Yes, I think closing it and making a new PR could be a good idea. I'll be sure to review it as soon as you do. I'm hoping we'll be able to get a new release of HTMLHint out soon. thanks again!

[chrisguttandin]

Okay, I rebased the branch on top of master. Could you please take a look, @coliff?

[coliff]

Okay, I rebased the branch on top of master. Could you please take a look, @coliff?

I think if you run npm run build and include the updated files in the dist directory (it should update htmlhint.js and htmlhint.min.js then we should be good to merge!

[chrisguttandin]

I think if you run npm run build and include the updated files in the dist directory (it should update htmlhint.js and htmlhint.min.js then we should be good to merge!

Okay, I just did that.

[coliff]

thanks @chrisguttandin - nearly there! There's a test failure though.....

 FAIL test/rules/attr-sorted.spec.js
    ● Rules: attr-sorted › Attribute unsorted tags that are unrecognizable should throw error
  
      TypeError: Cannot read properties of undefined (reading 'be')
  
        30 |     const messages = HTMLHint.verify(code, ruleOptions)
        31 |
      > 32 |     expect(messages.length).to.be(1)
           |                               ^
        33 |     expect(messages[0].rule.id).to.be(ruleId)
        34 |     expect(messages[0].message).to.contain('["img","meta","font"]')
        35 |   })
  
        at Object.<anonymous> (test/rules/attr-sorted.spec.js:32:31)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (32d427f) to head (4bcc417).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files           2        2           
  Lines        1627     1627           
  Branches      340      342    +2     
=======================================
  Hits         1602     1602           
  Misses         25       25           

Files with missing lines	Coverage Δ
dist/htmlhint.js	98.46% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d427f...4bcc417. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[chrisguttandin]

Thanks @coliff, for taking care of the failing tests. I scratched my head wondering why I created these failing tests in the first place. It turns out I created the PR before the switch to Jest. :-) I'm happy that it's finally merged. Thanks a lot.