-
Notifications
You must be signed in to change notification settings - Fork 6k
[hybrid inference 🍯🐝] Wan 2.1 decode #11031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
512, | ||
) | ||
endpoint = DECODE_ENDPOINT_WAN_2_1 | ||
dtype = torch.float16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @yiyixuxu Currently the endpoint is running in float16 and output seems ok (on random latent), the examples use float32 but we noticed in the original code that everything is under bfloat16 autocast context. Can we check with the authors regarding the use of float32 for VAE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i haven't heard back from them,
maybe let's generate some sample comparison and ask @asomoza to help decide if there is a quality difference
@@ -176,18 +177,6 @@ def test_output_type_pt_partial_postprocess_return_type_pt(self): | |||
f"{output_slice}", | |||
) | |||
|
|||
def test_do_scaling_deprecation(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wan VAE doesn't have a scaling_factor
that we could pass, so this deprecation/removing do_scaling
doesn't work, we will keep it.
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Rebase after #11017
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.