-
Notifications
You must be signed in to change notification settings - Fork 6k
fix xlabs FLUX lora conversion typo #9581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix xlabs FLUX lora conversion typo #9581
Conversation
Thank you for this. The reason why, it was not brought up because we don't test for an Xlabs LoRA that has diffusers/tests/lora/test_lora_layers_flux.py Line 252 in 99f6082
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@sayakpaul from a cursory glance from my phone it seems the failed test is unrelated to the diff of this PR |
@Clement-Lelievre possible to push an empty commit? |
done |
Failing test is completely unrelated. |
Thank you for the PR! |
@sayakpaul as follow-up, using the same xlabs lora the conversion now works, however I now get the error: Possibly because |
Can you open a new issue with a reproducible snippet? |
* fix startswith syntax in xlabs lora conversion * Trigger CI huggingface#9581 (comment)
* fix startswith syntax in xlabs lora conversion * Trigger CI #9581 (comment)
What does this PR do?
Typo fixing for XLab FLUX LoRA conversion to diffusers.
In its current version, this raises:
TypeError: slice indices must be integers or None or have an __index__ method
becausestr.startswith
expects a tuple of strs or a single str.(Unless I've missed an issue on this topic, I'm a bit surprised this typo has been here for over a month without anyone complaining)
Repro steps:
pipe.load_lora_weights(xlab_lora)
, passing the lora from step 2Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul , @yiyixuxu