Skip to content

Optional credentials #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InDieTasten opened this issue May 28, 2018 · 5 comments
Open

Optional credentials #3

InDieTasten opened this issue May 28, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@InDieTasten
Copy link

As far as I can see, the only reason for having to provide credentials for this software is to be able to pull images from private repos on docker hub.

Would it be possible to make the software not crash, but skip docker login, if the credentials are omitted? This way, one wouldn't have expose credentials and having to keep them updated, if passwords change, etc.

@InDieTasten
Copy link
Author

I'd be willing to create a PR, if there was a suitable license for me to do that.

imjosh added a commit to imjosh/docker-deploy-webhook that referenced this issue Jun 2, 2018
Add support for optional credentials
@levino
Copy link
Contributor

levino commented Jun 14, 2018

What is the usecase? You want to redeploy your mongodb everytime a new image is pushed? I think it is quite unreasonable to automate redeployment for images you do not control / which are public. You should do this for your apps, not your dependencies.

@imjosh
Copy link

imjosh commented Jun 14, 2018

The use case is for images that you control that are also public. Or, if you want to live by the seat of your pants and re-deploy mongo whenever they update their image, that's your choice to make.

@InDieTasten
Copy link
Author

For me personally, that is exactly the case. I have a public repo I control, and I don't want to put my credentials at yet another place. It's a demo service, which will be updated frequently and I like to automate my processes such that completing a PR to my master will CI and CD straight to the demo slot.

@iaincollins
Copy link
Owner

Thanks for raising this and for the PR! 💯

@iaincollins iaincollins self-assigned this Jul 5, 2018
@iaincollins iaincollins added the enhancement New feature or request label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants