Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error when alert has not fingerprint #250

Closed
jperera opened this issue Feb 17, 2021 · 1 comment
Closed

[BUG] Error when alert has not fingerprint #250

jperera opened this issue Feb 17, 2021 · 1 comment
Assignees

Comments

@jperera
Copy link
Contributor

jperera commented Feb 17, 2021

Description

Alert without fingerprint launches an error:

File "/home/jperera/Developer/idealista/prom2teams/prom2teams/teams/alert_mapper.py", line 83, in _teams_visualization
return FIELD_SEPARATOR.join(OrderedDict.fromkeys(field)) if field else 'unknown'

Steps to Reproduce

  1. Make a request with alert without fingerprint

Expected behavior:

Return 200 and send de notification to teams

Actual behavior:

File "/home/jperera/Developer/idealista/prom2teams/prom2teams/teams/alert_mapper.py", line 83, in _teams_visualization
return FIELD_SEPARATOR.join(OrderedDict.fromkeys(field)) if field else 'unknown'

Reproduces how often:
Always

Environment

Version 3.2.0

@jperera jperera added the bug label Feb 17, 2021
@jperera jperera changed the title [BUG] Fail when alert has not fingerprint [BUG] Error when alert has not fingerprint Feb 17, 2021
@jperera jperera self-assigned this Feb 17, 2021
jperera added a commit that referenced this issue Feb 17, 2021
#250 Fix error when alert has not fingerprint
@stale
Copy link

stale bot commented Apr 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants