Allow to add arbitrary envvars to deployment #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements feature request in issue idealista#239 Signed-off-by: Daniel Kobras <kobras@puzzle-itc.de>
|
Hi @dkobras, LGTM! Could you add a entry to the CHANGELOG.md? |
vicsufer
requested review from
vicsufer,
antonioarenzanapulido,
blalop,
dortegau,
emepege,
frantsao,
jmonterrubio,
jperera,
sorobon,
ultraheroe and
xtianae7
vicsufer
approved these changes
Nov 11, 2021
xtianae7
approved these changes
Nov 11, 2021
blalop
approved these changes
Nov 11, 2021
|
Thanks for the contribution @dkobras! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
No additional requirements are introduced by this change.
Description of the Change
Extend helm templates to allow to specify additional arbitrary environment variables to be passed to deployment.
Benefits
Allow further customization of deployment from Helm template. For example, if teams server can only be reached via a proxy, variables
HTTP_PROXYand/orHTTPS_PROXYcan be configured via the newly introduced prom2teams.extraEnv helm setting.Possible Drawbacks
New setting is optional, hence no drawbacks.
Applicable Issues
Feature has been requested in issue #239 (already closed due to inactivity)