Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add arbitrary envvars to deployment #281

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

dkobras
Copy link
Contributor

@dkobras dkobras commented Nov 11, 2021

Requirements

No additional requirements are introduced by this change.

Description of the Change

Extend helm templates to allow to specify additional arbitrary environment variables to be passed to deployment.

Benefits

Allow further customization of deployment from Helm template. For example, if teams server can only be reached via a proxy, variables HTTP_PROXY and/or HTTPS_PROXY can be configured via the newly introduced prom2teams.extraEnv helm setting.

Possible Drawbacks

New setting is optional, hence no drawbacks.

Applicable Issues

Feature has been requested in issue #239 (already closed due to inactivity)

Implements feature request in issue idealista#239

Signed-off-by: Daniel Kobras <kobras@puzzle-itc.de>
@vicsufer
Copy link
Collaborator

Hi @dkobras, LGTM! Could you add a entry to the CHANGELOG.md?

@vicsufer vicsufer merged commit 0ab711f into idealista:develop Nov 12, 2021
@vicsufer
Copy link
Collaborator

Thanks for the contribution @dkobras!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants