Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Fall back to shift if alpha is too big #55

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

hongyuanjia
Copy link
Member

@hongyuanjia hongyuanjia self-assigned this May 5, 2022
@hongyuanjia hongyuanjia added the enhancement New feature or request label May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #55 (131b052) into master (79ab667) will decrease coverage by 42.76%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #55       +/-   ##
===========================================
- Coverage   99.82%   57.06%   -42.77%     
===========================================
  Files           5        5               
  Lines        1167     1218       +51     
===========================================
- Hits         1165      695      -470     
- Misses          2      523      +521     
Impacted Files Coverage Δ
R/esgf.R 98.78% <ø> (-1.22%) ⬇️
R/morph.R 0.22% <0.00%> (-99.78%) ⬇️
R/coord.R 74.78% <0.00%> (-25.22%) ⬇️
R/netcdf.R 90.15% <0.00%> (-9.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44cc26...131b052. Read the comment docs.

@hongyuanjia hongyuanjia added this to the v0.2.0 milestone May 5, 2022
@hongyuanjia hongyuanjia merged commit c926920 into master Jun 27, 2022
@hongyuanjia hongyuanjia deleted the feat/alpha-warning branch June 27, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpha values could be quite big and thus introduce results far from reality
2 participants