fix: use absolute app path in igniteapps.yaml
#4705
Conversation
github-actions
bot
added
component:ci
|
tests are failing with incorrect plugin names: https://github.com/ignite/cli/actions/runs/15266584488/job/42933260914?pr=4705 |
| pluginPath = pluginPathAbs | ||
| } | ||
| // This is a local plugin, check if the directory exists | ||
| if filepath.IsAbs(pluginPath) { |
There was a problem hiding this comment.
lgtm, but, what if you already have relative paths in your igniteapp.yml in your chain locally and in an app.
Maybe ignite doctor should do something about it (or simply fail if that's the case)
There was a problem hiding this comment.
We are already using only the absolute path here. We filter at the top level of the application. If it is a relative path, we convert it to an absolute path. In this part, the path is already absolute
There was a problem hiding this comment.
ok, just tried
$ ignite app install ../../projects/ignite/apps/connect/
✔ Done loading apps
🎉 Installed ../../projects/ignite/apps/connect/
$ cat igniteapps.yml
apps:
- path: ../../projects/ignite/apps/connect/
from the previous version, and try to run with the new one and it kept working 👍🏾
Just uninstalling and describing doesn't work if using a relative path, but i think that's a ok tradeoff. I was more worried about the apps not being loaded.
There was a problem hiding this comment.
lgtm! but i think we need to do something in case an user is already using relative paths (#4705 (comment)).
Probably ignite doctor should just error if it finds a relative path in an igniteapp.yml (no need to try to make them absolute, as relative paths are ambiguous)
close #4694