-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reporting (phase 2) #150
Conversation
The errors (I found them here in the Travis build log) occur because
These lines in
…but it looks like they never complete. No clue why this is occurring—maybe a one-time glitch on Travis' workers? Will dig more… |
I also got an error on the aggregation test locally (on the rebase effort, not the merge effort)
|
restarting CI for failed job to see if that helps.. |
went ahead and cherry-picked the commit in #149 here to keep moving forward |
- use partial() in Key.aggregates() to encode string arguments.
As of now this branch is feature-complete for the portions we intend to include in ixmp 0.2/message_ix 1.2. Further commits should only be made in order to help complete iiasa/message_ix#206. |
Should we add a warning in the docs that reporting is only py3 compatible? |
FYI @khaeru I tried rebasing #144 on the new master, but got a weird test error. If I merge (fastforward), I get no such issue. If you want to give the rebasing a try, please feel free.
This is built on #144, text is copied for reference below:
This will implement the second phase of the reporting update. Supersedes #126 which was from a branch in a fork; all can commit to this branch. See there for more comments & discussion.
See also:
message_ix
.Progress
Address requirements from wiki:
A3iii. Interpolation: linear, exponential, etc.deferred to after 0.2A7ii. …loaded from file.deferred to after 0.2retixmp
(tests require Test rixmp using 'testthat' #135)PR checklist:
Miscellaneous:
dask[array]
(thustoolz
),graphviz
(for dask.visualize),pint
, andxarray
. Should these be non-optional requirements, or extras (ixmp[reporting]
)?data_for_quantity()
is needed;keys_for_quantity()
only loads metadata.set_filters()
to filter item data ex ante, i.e. before other computations take place, by using existing functionality indata_for_quantity()
.