-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): fix thumbnail hover link overflowing past thumbnail bounds #16762
base: main
Are you sure you want to change the base?
Conversation
…mages on the search page
This comment was marked as outdated.
This comment was marked as outdated.
@@ -241,7 +241,7 @@ | |||
class="absolute z-30 {className} top-[41px]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you do this?
class="absolute z-30 {className} top-[41px]" | |
class="absolute z-20 {className} top-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I tested previously, this offset is needed, otherwise you can't click on the checkmark to actually start the selection process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I figured out a solution.
Change z-30
to z-20
and on the div below change z-20
to z-30
and you can then set 0 like in my suggestion.
Correction, this issue does occur on |
Description
This fixes the height and z-index of the
<a>
element when hovering over asset thumbnails. Because thea
element is absolutely positioned and shifted down 41px, it was possible navigate to the asset by clicking below the thumbnail when you didn't intend to navigate to it. Now that the z-index is correct, the element no longer has to be offset, fixing the link position.This also fixes the search page showing scrollbars when hovering over thumbnails from the last row of results on the search results page.
How Has This Been Tested?
Screenshots (if appropriate)
Before:

After:

Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)