feat(server): sidecar in asset_files #16827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
etnoy
commented
Mar 12, 2025
etnoy
commented
- add new sidecar type in asset_files
- remove sidecarPath from asset
- create dedicated assetFileRepository
…-app/immich into feat/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…-app/immich into feat/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/inline-offline-check
…/sidecar-asset-files
…/sidecar-asset-files
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
2 times, most recently
from
ae1d2ee to
43eb083
Compare
bo0tzz
reviewed
Mar 12, 2025
| @@ -18,12 +18,15 @@ export class AssetFileEntity { | |||
| id!: string; | |||
|
|
|||
| @Index('IDX_asset_files_assetId') | |||
| @Column() | |||
| @Column({ nullable: true, default: null }) | |||
There was a problem hiding this comment.
Is it a good idea to make this nullable?
There was a problem hiding this comment.
Sidecars are now discovered independently of files in library scans can are possibly orphans
| name = 'Test1741731070431'; | ||
|
|
||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(`ALTER TABLE "assets" DROP COLUMN "sidecarPath"`); |
There was a problem hiding this comment.
Should this move the existing sidecar paths over to asset_files rather than just dropping them?
There was a problem hiding this comment.
I'll think about this later
| @GenerateSql({ | ||
| params: [{ libraryId: DummyValue.UUID, importPaths: [DummyValue.STRING], exclusionPatterns: [DummyValue.STRING] }], | ||
| }) | ||
| async detectOfflineExternalSidecars( |
There was a problem hiding this comment.
Sidecars are already treated as malleable, so I don't think sidecar handling should need any special cases for external.
There was a problem hiding this comment.
This is a speedup that we can do for external assets
…/sidecar-asset-files
…/sidecar-asset-files
etnoy
force-pushed
the
feat/sidecar-asset-files
branch
from
43eb083 to
ec9d538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.