-
Notifications
You must be signed in to change notification settings - Fork 18
Bump react-router-dom from 6.14.1 to 6.15.0 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
【CIで落ちていた箇所】 Run yarn run lint
Run yarn run build
|
📝 今回変更されるパッケージ
ライブラリの差分
|
上記のエラーについて、開発環境で実行したが |
638d7cc
to
54a91f8
Compare
@kyntk
以下引用
|
A newer version of react-router-dom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@kimkim0814 レビューが遅くなり申し訳ございません。 lintがfailしていた原因を調査してみたのですが、型定義が古いことが起因していそうです。 最新のバージョンに上げたところエラーは起きなかったので、skipLibCheckをするのではなく、この方法のほうが良さそうだと思いました $ yarn remove @types/react @types/react-dom
$ yarn add -D @types/react@latest @types/react-dom@latest
$ yarn run lint +dependabot/npm_and_yarn/react-router-dom-6.15.0
yarn run v1.22.19
$ run-p lint:*
$ prettier --check .
$ eslint .
$ tsc --noEmit
Checking formatting...
All matched files use Prettier code style!
✨ Done in 9.44s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コメント済み
54a91f8
to
821310c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
821310c
to
c39c84c
Compare
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.14.1 to 6.15.0. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@6.15.0/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c39c84c
to
505f0df
Compare
Bumps react-router-dom from 6.14.1 to 6.15.0.
Release notes
Sourced from react-router-dom's releases.
... (truncated)
Changelog
Sourced from react-router-dom's changelog.
Commits
e79cb77
chore: Update version for release (#10776)cd1e25a
chore: Update version for release (pre) (#10771)d6d0e5b
Merge branch 'main' into release-nextfb70fed
Do not include hash in useFormAction() for unspecified actions (#10758)46806a4
Add support to force reload on redirect withX-Remix-Reload-Document
header...b23d7b5
Fix docs on NavLink w.r.t. links to the root route and the end prop (#10757)4bdd6b4
Add setTimeout back to unstable_usePrompt (#10718)78ef4ef
Stabilize useRevalidator (#10707)172bad7
Merge branch 'release-next' into dev1acea8b
chore: Update version for release (#10711)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)