Code ADR for mithril-common #2343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
approved these changes
Feb 27, 2025
Alenar
force-pushed
the
djo/2342/code-adr
branch
from
5c72962 to
eb6ff85
Compare
Alenar
force-pushed
the
djo/2342/code-adr
branch
from
eb6ff85 to
b7b5691
Compare
dlachaume
approved these changes
Mar 5, 2025
Alenar
force-pushed
the
djo/2342/code-adr
branch
from
b7b5691 to
fd0a853
Compare
- We want to have only one file to avoid fragmentations (some ADR can concerns multiple projects). - The name is to help differentiate this file from the website blog ADR (that record more structural decisions).
- specify that all check jobs must have passed instead of only clippy - specify that a ADR blog post or a DevADR entry should be added if relevant - specify that no new TODOs should be added to keep the project clean
Alenar
force-pushed
the
djo/2342/code-adr
branch
from
fd0a853 to
f63bce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a "code ADR" file to the
mithril-commonproject in order to details project specific decisions that would be to specific to fit our website ADR blog.Pre-submit checklist
Issue(s)
Relates to #2342