Add man page for cpa_sample_code #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
gcabiddu
approved these changes
Apr 29, 2025
gcabiddu
reviewed
Apr 29, 2025
| @@ -322,7 +322,7 @@ if SERVICE_AC | |||
| fi | |||
| endif | |||
|
|
|||
| dist_man_MANS = qat_init.sh.8 qatmgr.8 | |||
| dist_man_MANS = qat_init.sh.8 qatmgr.8 cpa_sample_code.7 | |||
There was a problem hiding this comment.
I haven't checked the creation of the Fedora RPM, but I think this will require a small change in the spec file to include this file (otherwise the RPM creation will be broken).
Line 101 in 240991f
%files tests
...
%{_mandir}/man7/cpa_sample_code.7*
There was a problem hiding this comment.
Hi @ColinIanKing, just confirming that this change is breaking the build of the rpm on Fedora. This can be tested with make rpm.
Can you just add the following change to this PR?
diff --git a/qatlib.spec.in b/qatlib.spec.in
index c5c3e9f29f7c..531f14ccda35 100644
--- a/qatlib.spec.in
+++ b/qatlib.spec.in
@@ -123,6 +123,7 @@ exit 0
%{_datadir}/qat/calgary
%{_datadir}/qat/calgary32
%{_datadir}/qat/canterbury
+%{_mandir}/man7/cpa_sample_code.7*
%files service
%{_sbindir}/qatmgr
Don't worry about updating the changelog or bumping up the build number on the Release filed.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual is missing for this binary and this is required for Debian packages. Add it.