Skip to content

fix: consider binding when running autocomplete functions #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

fractal13
Copy link
Contributor

Pull Request Type

  • Feature addition
  • [ X] Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Autocomplete functions implemented as methods of a Client subclass are not called with binding to the client object. This causes the autocomplete call to raise an exception. This PR fixes the issue.

Changes

  • Call autocomplete methods with object binding.

Related Issues

#1582

Test Scenarios

Issue #1582 has a script that demonstrates the failure before this patch, and success after this patch.

Python Compatibility

  • [X ] I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • [ X] I've run the pre-commit code linter over all edited files
  • [ X] I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

There were no autocomplete tests prior to this, and I did not add any to the tests/ directory.
No documentation should need to be updated.

@AstreaTSS AstreaTSS changed the title Bug fix for calling autocomplete as method of Client subclass. Issue#1582 fix: consider binding when running autocomplete functions Nov 30, 2023
@fractal13 fractal13 requested a review from AstreaTSS November 30, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants