-
Notifications
You must be signed in to change notification settings - Fork 187
feat: add Member.has_any_role #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Member.has_any_role #1620
Conversation
While I do appreciate the PR (because I think it's still useful), this isn't what the documentation says. It specifically says that it's for checks, not for the actual user.py, and never says that Thus, this is fully a feature addition, not a bug fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add the typing of the function to user.pyi
too, found in the same folder.
PR is on track for becoming stale |
Pull Request Type
Description
This PR fixes has_any_role() not working on member object by adding it to user.py and makes it work as originally documented.
Changes
Test Scenarios
Use has_any_role() on member object.
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files