Skip to content

fix: Correct the return type of fetch_channels #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

retr0-init
Copy link
Contributor

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Correct the return type of guild.fetch_channels from VoiceChannel to TYPE_GUILD_CHANNEL

Changes

  • Change the return type of the function fetch_channels from TYPE_VOICE_CHANNEL to TYPE_GUILD_CHANNEL

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

Developer89899 and others added 2 commits November 30, 2023 20:46
5.11.0
Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free pr (though with a change needed)

This is meant to be TYPE_VOICE_CHANNEL due to it being a GuildWidget, so this should be reverted.
interactions-py#1622 (review)

Signed-off-by: retr0-init <146389702+retr0-init@users.noreply.github.com>
@AstreaTSS AstreaTSS changed the base branch from stable to unstable February 28, 2024 22:46
@AstreaTSS AstreaTSS merged commit 6c12971 into interactions-py:unstable Feb 28, 2024
@retr0-init retr0-init deleted the patch-2 branch February 28, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants