Skip to content

5.12.1 #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
May 6, 2024
Merged

5.12.1 #1677

5 commits merged into from
May 6, 2024

Conversation

silasary
Copy link
Member

@silasary silasary commented May 6, 2024

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Hotfix: Bump minimum version of discord-typings to match the things we're importing

Changes

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (1a7de56) to head (37e73c7).
Report is 49 commits behind head on stable.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1677      +/-   ##
==========================================
+ Coverage   45.95%   46.22%   +0.26%     
==========================================
  Files         144      148       +4     
  Lines       15492    15772     +280     
==========================================
+ Hits         7120     7291     +171     
- Misses       8372     8481     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AstreaTSS and others added 3 commits May 6, 2024 15:06
* fix: hook onto add_command to propagate errors correctly

* fix: re-add on_callback_added to add_hybrid_command
@silasary silasary enabled auto-merge May 6, 2024 05:16
@silasary silasary closed this pull request by merging all changes into stable in a8f6fcf May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants