fix package.json types entry #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I installed the package the typescript definition ended up in: node_modules/@intercom/intercom-react-native/lib/typescript/src/index.d.ts
|
Someone merge this lol.. types is broken on |
|
Wild.. Intercom has been a rollercoaster.. |
KarlosQ
approved these changes
Feb 28, 2024
|
I am shocked this made it to a release.. |
Get me off this wild ride 😭 |
|
+1 |
liutingdu
approved these changes
Feb 29, 2024
|
+1 |
TNAJanssen
approved these changes
Feb 29, 2024
|
Hey everyone 👋 Thank you all for your patience and understanding as we work through this. |
uddish
pushed a commit
that referenced
this pull request
Mar 13, 2024
When I installed the package the typescript definition ended up in: node_modules/@intercom/intercom-react-native/lib/typescript/src/index.d.ts Co-authored-by: Alexander Trousevich <me@trousev.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I installed the package the typescript definition ended up in:
node_modules/@intercom/intercom-react-native/lib/typescript/src/index.d.ts
not sure if this is the correct fix or of the build can instead put the types file in the typescript folder without the src folder.