Do not access attributes that don't match the method selector regex #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Otherwise properties on objects might trigger even though they're not matched by an aspect. It's unavoidable for those attributes that do match the method selector, but we don't have to read unrelated attributes.
|
Alright, please also update authors/changelog.rst. |
whoops. Done. I guess the CI needs some love too :/ |
|
I'll fix that, looks like some configuration is too old. |
|
Looks like I forgot about this. There will be a release soonish. |
bmwiedemann
referenced
this pull request
in bmwiedemann/openSUSE
Apr 27, 2020
https://build.opensuse.org/request/show/796582 by user scarabeus_iv + dimstar_suse - update to 1.5.0 * Fixed ``weave`` to stop reading attributes that don't match the method selector. Contributed by Jonas Maurus in `#14 <https://github.com/ionelmc/python-aspectlib/pull/14>`_. * Added support for Python 3.7 and 3.8 (``async def`` functions and generators). * Added a convenience ``weave`` fixture for pytest. - Launch tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only evaluate attributes after we know they match the method selector.
Otherwise properties on objects might trigger even though they're not matched by an aspect. Calling
getattris unavoidable for those attributes that do match the method selector, but we can avoid reading unrelated attributes.Sometimes developers do stupid things when attributes are read, like going to the network to read a remote API to get the value. PyGithub, for example, does that. So the order of these instructions, i.e. when precisely we access attributes to apply aspects can make a huge difference.