This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Adding ignore globs to fsadd. #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed ipfs-inactive#408 whilst in the area - `util.addFromFs` goes up almost to the root directory for files. It looks like for directories it was fixed in 42ccb00, but it is now fixed for files too.
daviddias
approved these changes
Jan 10, 2017
| @@ -150,10 +150,10 @@ Complete documentation for these methods is coming with: https://github.com/ipfs | |||
|
|
|||
| > `ipfs.util.addFromFs(path, option, callback)` | |||
|
|
|||
| Reads a file from `path` on the filesystem and adds it to IPFS. If `path` is a directory, use option `{ recursive: true }` to add the directory and all its sub-directories. | |||
| Reads a file from `path` on the filesystem and adds it to IPFS. If `path` is a directory, use option `{ recursive: true }` to add the directory and all its sub-directories. To exclude fileglobs from the directory, use option `{ ignore: ['ignore/this/folder/**', 'and/this/file'] }`. | |||
|
@JeffDownie CI fails on linting, could you run |
daviddias
suggested changes
Jan 10, 2017
There was a problem hiding this comment.
@JeffDownie CI fails on linting, could you run npm run lint locally and fix the errors?
|
@diasdavid Whoops! I got snowed under by the warnings returned from the linter for other files I hadn't touched and just kind of missed it, assumed it wasn't really adhered to! Should be good to go now though. |
daviddias
approved these changes
Jan 10, 2017
|
We let warnings pass, they are just remarks, but errors make CI fail. Thank you :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed #408 whilst in the area -
util.addFromFsgoes up almost to the root directory for files. It looks like for directories it was fixed in 42ccb00, but it is now fixed for files too.It looks like when the tests for this were written, someone expected addFromFs to go all the way up to the root dir in '.fsAdd a file' test/ipfs-api/util.spec.js- this seems like bizzare behaviour to expect, so I changed it.