This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Allow files.cat to accept a cid instance #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
ghost
assigned
This was referenced Mar 21, 2018
daviddias
suggested changes
Mar 22, 2018
There was a problem hiding this comment.
@jacobheun can you update the interface-ipfs-core dep to get the CI green?
daviddias
approved these changes
Mar 22, 2018
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the spec addition at ipfs-inactive/interface-js-ipfs-core#243, allowing users to use the cid instance itself to cat files.
This has been tested against the added tests from ipfs-inactive/interface-js-ipfs-core#243 via
npm linkconnects ipfs/js-ipfs#1229