Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

path: add ToCid API #61

Closed
wants to merge 1 commit into from
Closed

path: add ToCid API #61

wants to merge 1 commit into from

Conversation

schomatis
Copy link

@schomatis schomatis commented Aug 30, 2022

Closes ipfs/go-cid#130. (This will need to be manually closed since it's in a different repo. seems this works)

@schomatis schomatis requested a review from Jorropo August 30, 2022 23:11
@schomatis schomatis self-assigned this Aug 30, 2022
@welcome
Copy link

welcome bot commented Aug 30, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Comment on lines +42 to +43
// TODO: Silently allowing IPNS though ParsePath doesn't validate the CID
// in that case.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this. I'm not sure what's the expected IPNS format; we might need to validate its CID either way.

@hacdias
Copy link
Member

hacdias commented Jun 6, 2023

This repository is no longer maintained and has been copied over to Boxo. We are now in the process of reviewing issues and PRs and moving the ones that are still relevant. This issue has been merged with a few other issues, and moved to ipfs/boxo#198.

@hacdias hacdias closed this Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Support parse (github.com/ipfs/go-path).Path
2 participants