Skip to content

Please re-publish 0.2.2 as 0.3.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
achingbrain opened this issue Jan 9, 2020 · 3 comments
Closed

Please re-publish 0.2.2 as 0.3.0 #20

achingbrain opened this issue Jan 9, 2020 · 3 comments

Comments

@achingbrain
Copy link
Member

#19 changed how pubsub subscriptions are listed from:

const subscriptions = await this._pubsub.ls()

to

const subscriptions = await this._pubsub.getTopics()

This in effect forces the user to upgrade to a newer version of whatever libp2p-pubsub subclass they are using but also arrives as a stealth upgrade if your package.json contains ^0.2.1 as the version for this module.

This is not a backwards compatible change so should not be a patch release.

Please revert #19, republish v0.2.1 as v0.2.3, then reapply #19 and publish it as 0.3.0.

@vasco-santos
Copy link
Member

vasco-santos commented Jan 9, 2020

hey @achingbrain , I intended to release the 0.3.0 and did not notice it

apparently my release alias got broken from my laptop change. will have a look now at this. Thanks for reporting it

@vasco-santos
Copy link
Member

everything is now released properly

@achingbrain
Copy link
Member Author

Thanks!

achingbrain added a commit to ipfs/js-ipfs that referenced this issue Jan 10, 2020
* feat: support UnixFSv1.5 metadata

Adds metadata support.

Specifying metadata:

```console
$ jsipfs add --mode=0777 --mtime=100000 ./foo.txt
```

Respecting exsting metadata:

```console
$ jsipfs add --preserve-mode --preserve-mtime ./foo.txt
```

Displaying metadata:

```console
$ jsipfs ls Qmfoo
-rw-r--r-- Nov 21, 2019, 09:46:23 AM CST bar.txt Qbar 0
```

* chore: update dep paths and jsdocs

* chore: fix linting

* fix: expose metadata in http api

* test: interface tests passing

* chore: update package.json with branches

* fix: support mtime as timespec

* fix: check mtime formatting in timezone agnostic way

* fix: do not run hrtime tests in the browser

* chore: upgrade interop tests

* chore: symlink ipfs dir for interop tests

* fix: build ipfs before running examples

* fix: expose mtime-nsecs to cli and add tests

* fix: export path to js-ipfs binary

* fix: support optional mtime

* fix: linting

* fix: pin datastore-pubsub version due to ipfs/js-datastore-pubsub#20

* chore: restore datastore-pubsub semver
oliveriosousa pushed a commit to ipfs-examples/js-ipfs-examples that referenced this issue Jul 26, 2021
* feat: support UnixFSv1.5 metadata

Adds metadata support.

Specifying metadata:

```console
$ jsipfs add --mode=0777 --mtime=100000 ./foo.txt
```

Respecting exsting metadata:

```console
$ jsipfs add --preserve-mode --preserve-mtime ./foo.txt
```

Displaying metadata:

```console
$ jsipfs ls Qmfoo
-rw-r--r-- Nov 21, 2019, 09:46:23 AM CST bar.txt Qbar 0
```

* chore: update dep paths and jsdocs

* chore: fix linting

* fix: expose metadata in http api

* test: interface tests passing

* chore: update package.json with branches

* fix: support mtime as timespec

* fix: check mtime formatting in timezone agnostic way

* fix: do not run hrtime tests in the browser

* chore: upgrade interop tests

* chore: symlink ipfs dir for interop tests

* fix: build ipfs before running examples

* fix: expose mtime-nsecs to cli and add tests

* fix: export path to js-ipfs binary

* fix: support optional mtime

* fix: linting

* fix: pin datastore-pubsub version due to ipfs/js-datastore-pubsub#20

* chore: restore datastore-pubsub semver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants