Skip to content

Generic package #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2020
Merged

Generic package #3

merged 7 commits into from
May 29, 2020

Conversation

apgrucza
Copy link

@apgrucza apgrucza commented May 28, 2020

Added the ability to build a generic Lambda package. The Lambda function retrieves its parameters at runtime from the AWS Systems Manager Parameter Store and AWS Secrets Manager. Also added a Lambda package for rotation of the RSA keys.

GitHub does not show the differences in build/build.js very well. I suggest using a different tool to view the changes for this file.

Also added GitHub CI and release workflows for generic packages.

@apgrucza apgrucza requested a review from cuichenli May 28, 2020 02:52
@cuichenli
Copy link

My only concern about getting parameters from the parameter store is that the users may need to find another tool/mechanism to store the parameters into the parameter store.

@apgrucza
Copy link
Author

I tried using environment variables for parameters but they're not supported for Lambda@Edge.

Most users would already be using a tool such as Terraform or CloudFormation to deploy their CloudFront distribution and Lambda function. But if they are manually deploying these then yes, they will also have to manually deploy the parameters/secrets.

I think generally users would want the parameters/secrets to be owned by Terraform or CloudFront so that their lifecycle is managed automatically, e.g. deleted when the CloudFront distribution is deleted. It also lets them set attributes such as tags and rotation rules in a consistent manner.

@apgrucza apgrucza merged commit ff883df into master May 29, 2020
@apgrucza apgrucza deleted the generic-package branch May 29, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants