Skip to content

Pass expiresIn as seconds rather than milliseconds #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Pass expiresIn as seconds rather than milliseconds #9

merged 1 commit into from
Jul 16, 2020

Conversation

apgrucza
Copy link

jsonwebtoken's expiresIn interprets numbers as seconds but strings (containing a number without units) as milliseconds!

@apgrucza apgrucza requested a review from cuichenli July 16, 2020 02:22
@apgrucza apgrucza merged commit 748a756 into master Jul 16, 2020
@apgrucza apgrucza deleted the session-duration-fix branch July 16, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuichenli cuichenli cuichenli approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apgrucza @cuichenli