-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect calculation of local contrast adaption in color edge detection #11
Open
iRi-E
wants to merge
1
commit into
iryoku:master
Choose a base branch
from
iRi-E:fix_local_contrast_adaption
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRi-E
added a commit
to iRi-E/blender-experiment
that referenced
this pull request
Dec 21, 2016
…tion This bug came from original GLSL version. See the corresponding bug report: iryoku/smaa#11
iRi-E
added a commit
to iRi-E/smaa-cpp
that referenced
this pull request
Jan 7, 2017
…tion This bug came from original GLSL version. See the corresponding bug report: iryoku/smaa#11
iRi-E
added a commit
to iRi-E/blender-experiment
that referenced
this pull request
Jan 13, 2017
…tion This bug came from original GLSL version. See the corresponding bug report: iryoku/smaa#11
iRi-E
added a commit
to iRi-E/blender-experiment
that referenced
this pull request
Jan 26, 2017
…tion This bug came from original GLSL version. See the corresponding bug report: iryoku/smaa#11
jntesteves
added a commit
to jntesteves/libretro-slang-shaders
that referenced
this pull request
Sep 14, 2021
…dge detection This is the fix from PR iryoku/smaa#11
jntesteves
added a commit
to jntesteves/smaa
that referenced
this pull request
Sep 14, 2021
Fix incorrect calculation of local contrast adaption in color edge detection This is the fix from PR iryoku#11
jntesteves
added a commit
to jntesteves/libretro-slang-shaders
that referenced
this pull request
Sep 14, 2021
Fix incorrect calculation of local contrast adaption in color edge detection This is the fix from PR iryoku/smaa#11
jntesteves
added a commit
to jntesteves/libretro-slang-shaders
that referenced
this pull request
Sep 14, 2021
Fix incorrect calculation of local contrast adaption in color edge detection This is the fix from PR iryoku/smaa#11
vvv-yeaf
added a commit
to vvv-yeaf/Torque3D
that referenced
this pull request
Sep 2, 2022
as describe in iryoku/smaa#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SMAAColorEdgeDetectionPS(), the calculations of left-left and top-top deltas are performed as:
and
However, these are not differences of neighboring pixels, so should be modified as follows:
and
Thanks!